Add comprehensive unit tests for TagHelpers and fix build configuration #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue of missing unit tests for TagHelpers in the project by adding comprehensive test coverage for the core TagHelper functionality.
What was done
Added Unit Tests (15 new tests)
ILocalizationService
, covering valid translations, null/empty keys, and non-existent keysBuild Configuration Fixes
Test Coverage Improvement
Before: 35 tests passing
After: 50 tests passing (+43% increase)
The new tests follow the existing patterns in the codebase:
TestContextHelpers
for consistent test setupComplex TagHelpers
Some TagHelpers were identified as requiring extensive mocking of Umbraco services (ActiveClassTagHelper, MacroTagHelper, UmbracoCacheTagHelper, etc.) and represent advanced integration scenarios. These would benefit from dedicated integration test infrastructure rather than unit tests.
Impact
This PR significantly improves the project's test coverage and ensures that the core TagHelper functionality is properly validated. All existing functionality remains unchanged, and no breaking changes were introduced.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.